Add computation metering to the new stdlib functions#2880
Merged
Conversation
SupunS
commented
Oct 19, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit e69d6bb Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
turbolent
reviewed
Oct 19, 2023
turbolent
left a comment
turbolent
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for adding this so quickly
dsainati1
approved these changes
Oct 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2880 +/- ##
=======================================
Coverage 79.40% 79.41%
=======================================
Files 334 334
Lines 78914 78926 +12
=======================================
+ Hits 62664 62676 +12
Misses 13943 13943
Partials 2307 2307
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #2879
Description
This PR only adds computation metering for the newly added functions:
String.joinfunction #2762mapin Fixed/Variable sized Array types #2737filterin Fixed/Variable sized Array types #2678reversein Fixed/Variable sized Array type #2654The remaining functions need to be metered in the stable-cadence branch since it can be a breaking change.
masterbranchFiles changedin the Github PR explorer